Skip to content

Implement #ruleName on class side #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marschall merged 1 commit into from
Jul 10, 2026
Merged

Implement #ruleName on class side #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ry/Grease-Pharo110-Slime-Core.package/GRDeprecatedApiProtocolRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Invalid use of deprecated API protocol.'
2 changes: 1 addition & 1 deletion ...ory/Grease-Pharo110-Slime-Core.package/GRDeprecatedApiProtocolRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Invalid use of deprecated API protocol.'
^ self class ruleName
4 changes: 4 additions & 0 deletions repository/Grease-Pharo110-Slime-Core.package/GRReSlimeBlockLintRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
name

@marschall marschall Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to superclass so the #name implementations in the two subclasses could be removed.

"for compatibility with old Pharo versions"
^ self class ruleName
4 changes: 4 additions & 0 deletions ...tory/Grease-Pharo110-Slime-Portability.package/GRAnsiBooleansRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Booleans'
2 changes: 1 addition & 1 deletion ...itory/Grease-Pharo110-Slime-Portability.package/GRAnsiBooleansRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Booleans'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...ry/Grease-Pharo110-Slime-Portability.package/GRAnsiCharactersRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Characters'
2 changes: 1 addition & 1 deletion ...ory/Grease-Pharo110-Slime-Portability.package/GRAnsiCharactersRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Characters'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...y/Grease-Pharo110-Slime-Portability.package/GRAnsiCollectionsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Collections'
2 changes: 1 addition & 1 deletion ...ry/Grease-Pharo110-Slime-Portability.package/GRAnsiCollectionsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Collections'
^ self class ruleName
4 changes: 4 additions & 0 deletions .../Grease-Pharo110-Slime-Portability.package/GRAnsiConditionalsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Conditionals'
2 changes: 1 addition & 1 deletion ...y/Grease-Pharo110-Slime-Portability.package/GRAnsiConditionalsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Conditionals'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...ory/Grease-Pharo110-Slime-Portability.package/GRAnsiConvertorRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Convertors'
2 changes: 1 addition & 1 deletion ...tory/Grease-Pharo110-Slime-Portability.package/GRAnsiConvertorRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Convertors'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...ry/Grease-Pharo110-Slime-Portability.package/GRAnsiExceptionsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Exceptions'
2 changes: 1 addition & 1 deletion ...ory/Grease-Pharo110-Slime-Portability.package/GRAnsiExceptionsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Exceptions'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...itory/Grease-Pharo110-Slime-Portability.package/GRAnsiStreamsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Streams'
2 changes: 1 addition & 1 deletion ...sitory/Grease-Pharo110-Slime-Portability.package/GRAnsiStreamsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Streams'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...itory/Grease-Pharo110-Slime-Portability.package/GRAnsiStringsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Strings'
2 changes: 1 addition & 1 deletion ...sitory/Grease-Pharo110-Slime-Portability.package/GRAnsiStringsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Strings'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...haro110-Slime-Portability.package/GRBasicNewInitializeMissingRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ '#basicNew initialize is missing'
2 changes: 1 addition & 1 deletion ...Pharo110-Slime-Portability.package/GRBasicNewInitializeMissingRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ '#basicNew initialize is missing'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...ro110-Slime-Portability.package/GRInvalidObjectInitializationRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Invalid object initialization'
2 changes: 1 addition & 1 deletion ...aro110-Slime-Portability.package/GRInvalidObjectInitializationRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Invalid object initialization'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...rease-Pharo110-Slime-Portability.package/GRNonPortableMessageRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Uses non portable message'
2 changes: 1 addition & 1 deletion ...Grease-Pharo110-Slime-Portability.package/GRNonPortableMessageRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Uses non portable message'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...e-Pharo110-Slime-Portability.package/GRNotPortableCollectionsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Collections'
2 changes: 1 addition & 1 deletion ...se-Pharo110-Slime-Portability.package/GRNotPortableCollectionsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Collections'
^ self class ruleName
4 changes: 4 additions & 0 deletions repository/Grease-Pharo110-Slime-Portability.package/GRObjectInRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Object>>#in:'
2 changes: 1 addition & 1 deletion repository/Grease-Pharo110-Slime-Portability.package/GRObjectInRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Object>>#in:'
^ self class ruleName
2 changes: 1 addition & 1 deletion ...tPortableClassRule.class/instance/name.st → ...PortableClassRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name
ruleName

^ 'Uses not portable class'
2 changes: 1 addition & 1 deletion ...tPortableClassRule.class/instance/name.st → ...PortableClassRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name
ruleName

^ 'Subclasses not portable class'
4 changes: 4 additions & 0 deletions ...ry/Grease-Pharo110-Slime-Portability.package/GRTestAssertionsRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'TestCase >> #fail'
2 changes: 1 addition & 1 deletion ...ory/Grease-Pharo110-Slime-Portability.package/GRTestAssertionsRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'TestCase >> #fail'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...aro110-Slime-Portability.package/GRUsesCanPerformOrUnderstandRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Sends #canPerform: or #canUnderstand:'
2 changes: 1 addition & 1 deletion ...haro110-Slime-Portability.package/GRUsesCanPerformOrUnderstandRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Sends #canPerform: or #canUnderstand:'
^ self class ruleName
4 changes: 4 additions & 0 deletions .../Grease-Pharo110-Slime-Portability.package/GRUsesClassForHashRule.class/class/ruleName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
ruleName

^ 'Uses its class for hash'
2 changes: 1 addition & 1 deletion ...y/Grease-Pharo110-Slime-Portability.package/GRUsesClassForHashRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
accessing
name

^ 'Uses its class for hash'
^ self class ruleName
4 changes: 4 additions & 0 deletions ...ease-Pharo110-Slime-Portability.package/GRUsesNotPortableClassRule.class/instance/name.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
accessing
name

^ self class ruleName
Empty file added repository/Grease-Tests-Pharo-Slime.package/GRSlimeRuleTest.class/README.md
View file
Open in desktop
Empty file.
6 changes: 6 additions & 0 deletions ...ease-Tests-Pharo-Slime.package/GRSlimeRuleTest.class/instance/testUniqueIdentifierName.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
testing
testUniqueIdentifierName
"see https://github.com/SeasideSt/Grease/pull/202"
| result |
result := ReSmalllintTest run: #testUniqueIdentifierName.

@marschall marschall Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this so we have a test for #202

self assert: result hasPassed
11 changes: 11 additions & 0 deletions repository/Grease-Tests-Pharo-Slime.package/GRSlimeRuleTest.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"commentStamp" : "",
"super" : "TestCase",
"category" : "Grease-Tests-Pharo-Slime",
"classinstvars" : [ ],
"pools" : [ ],
"classvars" : [ ],
"instvars" : [ ],
"name" : "GRSlimeRuleTest",
"type" : "normal"
}
2 changes: 1 addition & 1 deletion repository/Grease-Tests-Pharo-Slime.package/monticello.meta/categories.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SystemOrganization addCategory: #'Grease-Tests-Pharo-Slime'!
self packageOrganizer ensurePackage: #'Grease-Tests-Pharo-Slime' withTags: #()!
Loading