Implement #ruleName on class side#210
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 87.84% 87.99% +0.15%
==========================================
Files 1607 1627 +20
Lines 11357 11439 +82
==========================================
+ Hits 9976 10066 +90
+ Misses 1381 1373 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marschall
commented
Jul 9, 2026
| testUniqueIdentifierName | ||
| "see https://github.com/SeasideSt/Grease/pull/202" | ||
| | result | | ||
| result := ReSmalllintTest run: #testUniqueIdentifierName. |
| @@ -0,0 +1,4 @@ | |||
| accessing | |||
| name | |||
Contributor
Author
There was a problem hiding this comment.
Moved to superclass so the #name implementations in the two subclasses could be removed.
jbrichau
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #208