GRSlime rules inherit from the RB rules thus are incorrectly identified#202
Merged
Merged
Conversation
tukanos
force-pushed
the
uniqueIdentifierName
branch
from
April 27, 2026 09:14
31149c7 to
10eb5ef
Compare
Pharo uses unique identifier to identify rule class. Since GRSlime rules inherit from RB rules they inherit also their unique identifier. This patch creates unique identifier for the GRSlime classes. For more information see test ReSmallLintTest>>testUniqueIdentifierName in Pharo
tukanos
force-pushed
the
uniqueIdentifierName
branch
from
April 27, 2026 10:03
10eb5ef to
0689aef
Compare
marschall
self-requested a review
July 8, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pharo uses unique identifier to identify rule class. Since GRSlime rules inherit from RB rules they inherit also their unique identifier. This patch creates unique identifier for the GRSlime classes.
For more information see test ReSmallLintTest>>testUniqueIdentifierName in Pharo