Remove dead oracle base classes: NoRECBase and DocumentRemovalOracleBase#1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes two abstract base classes in
src/sqlancer/common/oracle/:NoRECBase.javaDocumentRemovalOracleBase.javaBoth classes had zero subclasses and zero references outside their own files, confirmed by a full grep across the source tree. These may be remnants of incomplete or speculative work. The standard software engineering approach is to remove dead code because version control already archives it. If either class is needed in the future, it can be recovered from git history. If the main source stores dead code, it can risk misleading contributors and introducing unnecessary cognitive load.
This said, there may be good reasons for keeping these particular classes that I am not aware of, so please let me know your thoughts.