SVG export: add 'Z' close-path command for closed contours#1737
Open
AnibalPinto wants to merge 1 commit into
Open
SVG export: add 'Z' close-path command for closed contours#1737AnibalPinto wants to merge 1 commit into
AnibalPinto wants to merge 1 commit into
Conversation
Fixes solvespace#1368. For closed paths (loops), the SVG path definition now ends with 'Z' to explicitly close the path, rather than relying on the last point being equal to the first point. - Add virtual ClosePath() method to VectorFileWriter base class - Override ClosePath() in SvgFileWriter to emit ' Z' - Call ClosePath() in OutputLinesAndMesh when SBezierLoop::IsClosed() - Add export/svg/closed_path_has_z test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1368.
For closed paths (loops), the SVG path definition now ends with 'Z' to explicitly close the path, rather than relying on the last point being equal to the first point.