Fix Gtk-CRITICAL assertion in file chooser when opening files#1733
Merged
Conversation
Guard SetCurrentName() and SuggestFilename() calls against being invoked on open file dialogs, where GTK's gtk_file_chooser_widget_set_current_name asserts that the action is GTK_FILE_CHOOSER_ACTION_SAVE or GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER. Follow the same guard pattern already used in FilterChanged() and CheckForUntitledFile() in the same file.
Contributor
Author
|
This PR fixes #651 |
Member
|
@AnibalPinto Are you sure? I tried to reproduce #651 and don't have any problem. I go to Sketch->Image, and I select a png and it just works. BTW I'm running Gnome on Fedora 42 I think. |
Member
|
@AnibalPinto I take that back. I do get the debug message but it doesn't crash. This PR eliminates the message. Thank you for the contribution! |
Contributor
Author
|
@phkahler Thanks for the good first issue and Linux tags 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard SetCurrentName() and SuggestFilename() calls against being invoked on open file dialogs, where GTK's gtk_file_chooser_widget_set_current_name asserts that the action is GTK_FILE_CHOOSER_ACTION_SAVE or GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER.
Follow the same guard pattern already used in FilterChanged() and CheckForUntitledFile() in the same file.