Resolved problem when opening Select2 adding scroll prevention#6370
Open
pratik916 wants to merge 2 commits into
Open
Resolved problem when opening Select2 adding scroll prevention#6370pratik916 wants to merge 2 commits into
pratik916 wants to merge 2 commits into
Conversation
…t being removed if runtime scroll disappear due to dom changes. Added getter method when applying watchers and clearing them when select2 box is closed. Issue refered : select2#5342
Author
|
Resolving conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a
Resolved problem when opening Select2 adding scroll prevention was not being removed if runtime scroll disappear due to dom changes.
Added getter method when applying watchers and clearing them when select2 box is closed.
The following changes were made
This pull request includes changes to the
src/js/select2/dropdown/attachBody.jsfile to improve the handling of dropdown watchers. The most important changes include the addition of methods to manage watchers and refactoring existing code to utilize these new methods.Improvements to watcher management:
this.$watchersto store watcher elements._getWatchersfor retrieving watcher elements, replacing the previous inline implementation. [1] [2]_clearWatchersto clear the stored watchers._getWatchersand_clearWatchersmethods to manage the watcher elements more efficiently.If this is related to an existing ticket, include a link to it as well.