Skip to content

[3.6] bpo-31414: IDLE -- fix tk entry box tests by deleting first. (GH-3501) #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 1 commit into from
Sep 11, 2017
Merged

[3.6] bpo-31414: IDLE -- fix tk entry box tests by deleting first. (GH-3501) #3502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions Lib/idlelib/idle_test/test_configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,24 +1128,28 @@ def test_startup(self):

def test_editor_size(self):
d = self.page
d.win_height_int.insert(0, '1')
self.assertEqual(mainpage, {'EditorWindow': {'height': '140'}})
d.win_height_int.delete(0, 'end')
d.win_height_int.insert(0, '11')
self.assertEqual(mainpage, {'EditorWindow': {'height': '11'}})
changes.clear()
d.win_width_int.insert(0, '1')
self.assertEqual(mainpage, {'EditorWindow': {'width': '180'}})
d.win_width_int.delete(0, 'end')
d.win_width_int.insert(0, '11')
self.assertEqual(mainpage, {'EditorWindow': {'width': '11'}})

def test_autocomplete_wait(self):
self.page.auto_wait_int.insert(0, '1')
self.assertEqual(extpage, {'AutoComplete': {'popupwait': '12000'}})
self.page.auto_wait_int.delete(0, 'end')
self.page.auto_wait_int.insert(0, '11')
self.assertEqual(extpage, {'AutoComplete': {'popupwait': '11'}})

def test_parenmatch(self):
d = self.page
eq = self.assertEqual
d.paren_style_type['menu'].invoke(0)
eq(extpage, {'ParenMatch': {'style': 'opener'}})
changes.clear()
d.paren_flash_time.insert(0, '2')
eq(extpage, {'ParenMatch': {'flash-delay': '2500'}})
d.paren_flash_time.delete(0, 'end')
d.paren_flash_time.insert(0, '11')
eq(extpage, {'ParenMatch': {'flash-delay': '11'}})
changes.clear()
d.bell_on.invoke()
eq(extpage, {'ParenMatch': {'bell': 'False'}})
Expand All @@ -1158,12 +1162,14 @@ def test_autosave(self):
self.assertEqual(mainpage, {'General': {'autosave': '0'}})

def test_paragraph(self):
self.page.format_width_int.insert(0, '1')
self.assertEqual(extpage, {'FormatParagraph': {'max-width': '172'}})
self.page.format_width_int.delete(0, 'end')
self.page.format_width_int.insert(0, '11')
self.assertEqual(extpage, {'FormatParagraph': {'max-width': '11'}})

def test_context(self):
self.page.context_int.delete(0, 'end')
self.page.context_int.insert(0, '1')
self.assertEqual(extpage, {'CodeContext': {'numlines': '13'}})
self.assertEqual(extpage, {'CodeContext': {'numlines': '1'}})

def test_source_selected(self):
d = self.page
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2017-09-11-15-46-05.bpo-31414.wiepgK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
IDLE -- fix tk entry box tests by deleting first. Adding to an int entry is
not the same as deleting and inserting because int('') will fail.