bpo-45774: Harden SQLite detection#30016
Conversation
- Beautify configure output - Make sure vital functions are in place
Reindent contents of AC_ARG_ENABLE
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f5b0552 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Regarding the buildbot run: SQLite is correctly detected and the sqlite3 module is built, AFAICS. The two failures seem to be unrelated. |
|
@tiran, are you ok with this PR? For those of us who've got multiple SQLite installations with completely different configurations, it's nice to fail early with |
|
Regarding the buildbot run:
Both failures are unrelated to this PR. |
|
@tiran: 🏓 |
gpshead
left a comment
There was a problem hiding this comment.
I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library. But if they do, this likely does a better job at detecting that and avoiding it.
I do, I do! ✋🏻 (Mostly for testing weird stuff like this) OTOH, we never know what kind of SQLite library will show up when we're running Python in the browser. |
|
@tiran PPC64LE failure is sporadic, a rerun is required:
|
The buildbot started to fail consistently two days ago. I have contacted Charris to look into the problem an hour ago. |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
16 similar comments
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
@erlend-aasland: Status check is done, and it's a failure ❌ . |
|
The Windows refleak, PPC64LE, and s390x issues are unrelated to the PR. The s390x issue is addressed in GH-32332. |
https://bugs.python.org/issue45774
Automerge-Triggered-By: GH:tiran