bpo-31002: IDLE: Add tests for configdialog keys tab#2996
Conversation
|
The tests pass when run normally. But when checking for leaks in the new tests with test_keybinding (idlelib.idle_test.test_configdialog.KeyTest) ... Exception in Tkinter callback FAIL: test_builtin_name (idlelib.idle_test.test_configdialog.KeyTest) FAIL: test_create_new_key_set_and_save_new_key_set (idlelib.idle_test.test_configdialog.KeyTest) FAIL: test_keybinding (idlelib.idle_test.test_configdialog.KeyTest) I don't know the details of how the leak test works, but when I made a copy of KeyTest, renamed it KeyTest2, and hit F5, I got the same errors as above plus FAIL: test_on_bindingslist_select ( These failures indicate bugs in the setup or tear down of the class, all methods, or the individual methods that fail. I will be doing other things until Sunday evening or Monday that will prevent me from much before that. |
|
I was going to work on this, but now I cannot pull it to make a local branch. Perhaps if you updated it, I could. |
|
I've rebased and pushed the changes. When I ran the command |
|
Got it now. I asked to delete to branch earlier, as part of starting fresh, but it was not deleted. |
terryjreedy
left a comment
There was a problem hiding this comment.
python -m test -R: -ugui -v test_idle -m idlelib.idle_test.test_configdialog.KeyTest.*
no longer gives errors above. Just "test_idle leaked [1, 1, 1, 1] memory blocks, sum=4", which Victor Stinner agrees is a problem in block counting. The leak test passes when test_idle is run without restriction.
There is still self.assertEqual(b.get('anchor'), 'find'): AssertionError: '' != 'find' but this is a problem with event generation, which I already know is tempermental.
…2996) Patch by Cheryl Sabella. (cherry picked from commit 2f89646)
https://bugs.python.org/issue31002