bpo-45391: mark UnionType as a class in documentation#28757
Merged
Conversation
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
serhiy-storchaka
approved these changes
Oct 6, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
AlexWaygood
approved these changes
Dec 8, 2021
Fidget-Spinner
approved these changes
Dec 9, 2021
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
I'm merging this as this is more straightforward than the rest of the list mentioned on the bpo. Those need more deliberation.
Contributor
|
Thanks @gaborbernat for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2021
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net> (cherry picked from commit e2cfc89) Co-authored-by: Bernát Gábor <gaborjbernat@gmail.com>
|
GH-30004 is a backport of this pull request to the 3.10 branch. |
Member
|
Thanks @gaborbernat for catching this, and thank you @AlexWaygood for reminding me to check this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernát Gábor bgabor8@bloomberg.net
https://bugs.python.org/issue45391
Things to consider the type does show up as class now in documentation:
vs before
This PR only addresses the instance in the issue report, but we should discuss if we should change all such instances in this file (there are quite a few others suffering from the same problem).