[trivial, docs] make extra arguments of sorted() keyword-only#2706
Merged
Conversation
|
@rogalski, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @rhettinger to be potential reviewers. |
bitdancer
requested changes
Jul 14, 2017
bitdancer
left a comment
Member
There was a problem hiding this comment.
According to help/pydoc, which uses the argument-clinic generated syntax, the default for reverse is False (which makes sense if you think about it :)
bitdancer
approved these changes
Jul 14, 2017
Contributor
Author
|
Wow, thanks for such a rapid merge. I'll prepare a backport to 3.6 while I'm at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes discrepancy reported on SO: https://stackoverflow.com/questions/44756577