Skip to content

bpo-30869: regrtest: Add .idlerc to saved_test_environment#2614

Closed
mlouielu wants to merge 1 commit into
python:masterfrom
mlouielu:idlerc_changed
Closed

bpo-30869: regrtest: Add .idlerc to saved_test_environment#2614
mlouielu wants to merge 1 commit into
python:masterfrom
mlouielu:idlerc_changed

Conversation

@mlouielu

@mlouielu mlouielu commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

mention-bot commented Jul 7, 2017

Copy link
Copy Markdown

@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @cjerdonek and @benjaminp to be potential reviewers.

vstinner
vstinner requested changes Jul 7, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this idea: see the discussion on the issue.

@brettcannon

brettcannon commented Feb 2, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@terryjreedy

terryjreedy commented Mar 20, 2019

Copy link
Copy Markdown
Member

Closing as per Victor's suggestion

@mlouielu mlouielu mannequin mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mlouielu @mention-bot @brettcannon @terryjreedy @vstinner @the-knights-who-say-ni