Skip to content

bpo-40094: Enhance os.WIFEXITED documentation#19244

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:wifexited_doc
Apr 1, 2020
Merged

bpo-40094: Enhance os.WIFEXITED documentation#19244
vstinner merged 2 commits into
python:masterfrom
vstinner:wifexited_doc

Conversation

@vstinner

@vstinner vstinner commented Mar 31, 2020

Copy link
Copy Markdown
Member

@vstinner

Copy link
Copy Markdown
Member Author

@JulienPalard @deronnax: Would you mind to review this change? I used "man 2 waitpid" on my Fedora and combined it with the existing documentation.

Is it ok to backport such documentation enhancement to 3.7 and 3.8?

I was unhappy with WIFEXITED and WIFSIGNALED documentation. The difference between the two was unclear. I wrote this PR while working on PR #19201 documentation.

Comment thread Doc/library/os.rst Outdated
@vstinner

Copy link
Copy Markdown
Member Author

cc @pablogsal

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@vstinner vstinner merged commit 7c72383 into python:master Apr 1, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the wifexited_doc branch April 1, 2020 13:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2020
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-19277 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2020
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-19278 is a backport of this pull request to the 3.7 branch.

vstinner added a commit that referenced this pull request Apr 1, 2020
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Apr 1, 2020
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants