Skip to content

bpo-37091: subprocess - Handle uncaught PermissionError in send_signal #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesinator wants to merge 2 commits into from
Closed

bpo-37091: subprocess - Handle uncaught PermissionError in send_signal #13669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f78b2c7
Handle uncaught PermissionError in send_signal
wesinator May 29, 2019
56902e1
Move try to os.kill call only
wesinator May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,11 @@ def send_signal(self, sig):
"""Send a signal to the process."""
# Skip signalling a process that we know has already died.
if self.returncode is None:
os.kill(self.pid, sig)
try:
os.kill(self.pid, sig)
# Pass if operation not permitted
except PermissionError:
pass

def terminate(self):
"""Terminate the process with SIGTERM
Expand Down