gh-99485: Remove PyGen_New() function#100075
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Remove untested functions which were used to create generators and coroutines: * PyAsyncGen_New() * PyCoro_New() * PyGen_New() * PyGen_NewWithQualName() In Python 3.10, make_coro() of Python/ceval.c creates generators and coroutines from a frame object. In Python 3.11, the function became _Py_MakeCoro() in Python/genobject.c and it takes a function as argument instead of a frame.
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
Author
|
@Yhg1s says that removing 4 functions require to request a SC exception, so I requested such exception: python/steering-council#156 I mark this PR as a draft in the meanwhile, to not merge it by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove untested functions which were used to create generators and coroutines:
In Python 3.10, make_coro() of Python/ceval.c creates generators and coroutines from a frame object. In Python 3.11, the function became _Py_MakeCoro() in Python/genobject.c and it takes a function as argument instead of a frame.