Skip to content

Issue 526 Fixed#648

Merged
rosskukulinski merged 1 commit into
pkgcloud:masterfrom
sebastianfelipe:issue-526-solution
Mar 25, 2019
Merged

Issue 526 Fixed#648
rosskukulinski merged 1 commit into
pkgcloud:masterfrom
sebastianfelipe:issue-526-solution

Conversation

@sebastianfelipe

@sebastianfelipe sebastianfelipe commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

Issue 526 Fixed

  • this.protocol from client instance is used as the URL protocol as it should be
  • That value can be set in "options" when the azure client is set (i.e. using loopback-component-storage just write "protocol": "https://" or "http://" and for other uses, is the analog. By default is "https://")
  • The change is in just one line, no depth change was needed

@sebastianfelipe
Issue 526 Fixed
c64aaf1 
* this.protocol from client instance is used as the URL protocol as it should be
@sebastianfelipe sebastianfelipe mentioned this pull request Feb 4, 2019
Closed
@sebastianfelipe

sebastianfelipe commented Feb 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mrhillsman @mattgrande @kenperkins @stammen @indexzero @BobDickinson as simple as this. It needs to be merged. Thanks.

@coveralls

coveralls commented Feb 4, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 71.162% when pulling c64aaf1 on sebastianfelipe:issue-526-solution into 916fa68 on pkgcloud:master.

@dantman

dantman commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

I have the same issue and this patch appears to work.

@dantman dantman mentioned this pull request Feb 14, 2019
Open
@sebastianfelipe

sebastianfelipe commented Feb 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

That's not possible, beacuse it says http is constant in that string. It is necessary to add https to the requests. When http is used there's no problem with Azure, but http is too much open for Azure requests. Https is necessary instead.

@sebastianfelipe

sebastianfelipe commented Mar 25, 2019

Copy link
Copy Markdown
Contributor Author

Is there anybody that merge this to master please? Really need it @mrhillsman @mattgrande @kenperkins @stammen @indexzero @BobDickinson

@mrhillsman

mrhillsman commented Mar 25, 2019

Copy link
Copy Markdown

hey @sebastianfelipe unfortunately i do not have permissions on this repo

@rosskukulinski rosskukulinski merged commit ce4382f into pkgcloud:master Mar 25, 2019
@rosskukulinski

rosskukulinski commented Mar 25, 2019

Copy link
Copy Markdown
Contributor

@sebastianfelipe / @mrhillsman merged.

@sebastianfelipe

sebastianfelipe commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

Thanks! Everyone!

@sebastianfelipe

sebastianfelipe commented Mar 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rosskukulinski cannot download it correctly, I don't know if it is because some npm cache, or because it is necessary to add it or create a new release, call it 1.7.0.1 or 1.7.1 or something. I'd appreciate your help. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastianfelipe @coveralls @dantman @mrhillsman @rosskukulinski