Skip to content

Add basic completion for Keybase#6335

Closed
239 wants to merge 8 commits into
fish-shell:masterfrom
239:master
Closed

Add basic completion for Keybase#6335
239 wants to merge 8 commits into
fish-shell:masterfrom
239:master

Conversation

@239
Copy link
Copy Markdown
Contributor

@239 239 commented Nov 19, 2019

Description

Added first stage Keybase commands.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@ridiculousfish
Copy link
Copy Markdown
Member

@239 this doesn't merge cleanly after the merge of #6245, can you please rebase (and squash while you're at it?) Thanks!


#commands
complete -c keybase -f -n "not $seen $commands" -a "$commands"
#complete -c keybase -f -n "not $seen $commands" -a account -d "Modify your account"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why these are all commented out?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had started adding option descriptions but there are too many so I wanted just to add the completions for now.

@239
Copy link
Copy Markdown
Contributor Author

239 commented Dec 10, 2019

I have reworked the completions completely so this is not relevant anymore.

@239 239 closed this Dec 10, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants