Skip to content

print --help to stdout like other builtins#5495

Merged
floam merged 1 commit into
fish-shell:masterfrom
McKayJT:string-stdout
Jan 9, 2019
Merged

print --help to stdout like other builtins#5495
floam merged 1 commit into
fish-shell:masterfrom
McKayJT:string-stdout

Conversation

@McKayJT
Copy link
Copy Markdown
Contributor

@McKayJT McKayJT commented Jan 8, 2019

Description

Other builtins print --help to stdout so string should as well.

Found when string -h | less -R unexpectedly returned a pager with nothing in it.

Copy link
Copy Markdown
Member

@floam floam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floam floam merged commit a6fa237 into fish-shell:master Jan 9, 2019
@floam
Copy link
Copy Markdown
Member

floam commented Jan 10, 2019

Thanks @McKayJT!

@zanchey zanchey added this to the fish 3.1.0 milestone Jan 10, 2019
@zanchey zanchey added the bug Something that's not working as intended label Jan 10, 2019
@floam floam modified the milestones: fish 3.1.0, fish 3.0.1 Jan 23, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something that's not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants