fix: Restrict importlib.import_module to feast.* modules in error deserialization#6447
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Conversation
Prevent arbitrary code execution when a malicious server sends a crafted error response with a non-feast module name. The fix adds a prefix check ensuring only feast.* modules can be imported during error deserialization, with tests for non-feast rejection and legitimate feast errors. Signed-off-by: dfgvaetyj3456356-hash <dfgvaetyj3456356-hash@users.noreply.github.com>
f91b7f8 to
4a9ed9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a client-side remote code execution vulnerability in FeastError.from_error_detail().
CWE: CWE-94 (Code Injection)
File: sdk/python/feast/errors.py
FeastError.from_error_detail() used importlib.import_module() on an untrusted module field received from a server response. A malicious or compromised Feast server could send an error detail like {"module": "os", "class": "system", "message": "pwned"}, causing arbitrary module import and code execution on the client.
Fix: Restrict module_name to feast.* prefix only. Non-feast modules are rejected with a warning and return None.
Test: Added test_error_detail_blocks_non_feast_module() verifying that malicious non-feast modules are blocked.