fix: Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query#6311
Merged
ntkathole merged 1 commit intoApr 22, 2026
Conversation
8d6cc24 to
9e84c26
Compare
9e84c26 to
49f5031
Compare
49f5031 to
6c8b25c
Compare
ntkathole
approved these changes
Apr 22, 2026
…ll_from_table_or_query pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all source columns" signal used by FeatureBuilder.get_column_info for BatchFeatureView with TransformationMode.PYTHON, ray, and pandas — the generated SQL becomes: SELECT user_id, event_timestamp FROM source WHERE ... All raw feature columns (rating, text, helpful_vote, …) are silently dropped. The UDF receives a 2-column DataFrame and every aggregation returns null or fails. Fix: guard on feature_name_columns being non-empty before building the explicit projection; fall through to SELECT * when it is empty. Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
6c8b25c to
6d0c527
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pull_all_from_table_or_query always builds an explicit SELECT projection from join_key_columns + feature_name_columns + timestamp_fields. When feature_name_columns=[] — the "read all source columns" signal already used by FeatureBuilder.get_column_info for ray and pandas transformation modes — the generated SQL becomes:
All raw feature columns (rating, text, helpful_vote, etc.) are silently dropped. The UDF receives a 2-column DataFrame and every aggregation returns null or fails.
Why it happens