fix(spark): BatchFeatureView with TransformationMode.PYTHON now reads all source columns#6310
Merged
ntkathole merged 1 commit intoApr 22, 2026
Conversation
4070205 to
14b0203
Compare
14b0203 to
4614530
Compare
ntkathole
approved these changes
Apr 22, 2026
4614530 to
76ac945
Compare
Member
|
@abhijeet-dhumal seems pushed the different commits in this PR ? |
2139cff to
bd3d4a1
Compare
… all source columns Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
bd3d4a1 to
d956d09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FeatureBuilder.get_column_info() sets feature_cols=[] to signal "read all source columns" for transformation modes that compute output features from raw input. This signal was only applied for "ray" and "pandas" modes — "python" was missing.
TransformationMode.PYTHON is the default mode for @batch_feature_view. This means every default @batch_feature_view using SparkComputeEngine was broken out of the box.
Why it breaks
With feature_cols populated from the view's output schema (e.g. ["user_avg_rating", "user_review_count"]), the Spark offline store read step generates:
These output feature names don't exist in the raw source data — the UDF is supposed to compute them. Spark's analyzer throws:
Fix
Added "python" to the existing mode guard in get_column_info()
[x] Verified end-to-end on OpenShift AI with Feast 0.62.0 + PySpark 3.5.3 + MinIO + Redis — 2M+ feature vectors materialized successfully after fix