Add New Chat action and drop chat history overflow#8718
Open
GerardPaligot wants to merge 1 commit into
Open
Conversation
Ship review feedback flagged the chat history toolbar's overflow as redundant — its only entry duplicated the long-press affordance Android users already discover. The redesign adds a New Chat action so users can start a fresh conversation directly from this surface, drops the overflow icon, and shifts Fire to the trailing edge. Long-press becomes the canonical entry to select mode (already supported by the ViewModel, so no new wiring is needed).
15a734f to
b4b84ae
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b4b84ae. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1215237686779716?focus=true
Description
Reworks the chat history default toolbar per ship review feedback: adds a New Chat action (compose icon, opens Duck.ai for a fresh conversation), drops the overflow entry — whose single "Select" item duplicated the native long-press affordance — and shifts the Fire icon to the trailing edge. The new order is New · Search · Fire. Long-press on a row becomes the canonical entry to select mode.
Steps to test this PR
Note
Prerequisites:
Happy path — new default toolbar
New Chat action
Long-press is the entry to select mode
UI changes
Note
Low Risk
UI-only toolbar and navigation wiring; select mode still uses existing long-press and view-model paths.
Overview
Reworks the Duck.ai chat history default toolbar: adds a New action (
ic_compose_24) that opens a fresh Duck.ai session via the same path as the empty-state CTA, removes the overflow menu and its Select popup (that flow duplicated long-press), and reorders actions to New · Search · Fire with Fire on the trailing edge.ChatHistoryFragmentwires the new menu item, toggles New/Search visibility in select mode, and deletesshowToolbarOverflowPopuppluspopup_chat_history_overflow.xml. Copy dropsduck_ai_chat_history_action_selectand addsduck_ai_chat_history_action_new.Reviewed by Cursor Bugbot for commit b4b84ae. Bugbot is set up for automated code reviews on this repo. Configure here.