Skip to content

Add the translations for the texts used on the quick setup flow of the onboarding#8710

Open
catalinradoiu wants to merge 23 commits into
developfrom
feature/cradoiu/onboarding-quick-setup-translation
Open

Add the translations for the texts used on the quick setup flow of the onboarding#8710
catalinradoiu wants to merge 23 commits into
developfrom
feature/cradoiu/onboarding-quick-setup-translation

Conversation

@catalinradoiu
Copy link
Copy Markdown
Contributor

@catalinradoiu catalinradoiu commented May 28, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1142021229838617/task/1215176725605504?focus=true

Description

Translations for the quick setup texts from the onboarding flow.

Steps to test this PR

QA-Optional.

No UI changes


Note

Low Risk
String-resource and translation-only changes with no app logic; verify a few locales where onboarding step-indicator or quote strings were edited alongside the new keys.

Overview
This PR localizes the reinstall onboarding “quick setup” flow by moving English copy from donottranslate.xml into values/strings.xml and adding matching entries across locale strings.xml files.

New translated strings cover the welcome-back screen (default browser, home widget, address bar position/search options, Edit, Start Browsing), related bottom sheets (address bar placement, search vs Duck.ai, Done), and the three-step “remove home screen widget” instructions. Non-translatable step numbers (13) stay in donottranslate.xml.

A few locales also adjust unrelated onboarding copy (e.g. Dax search example quotes, step indicator wording); reviewers may want to spot-check cs, sk, pl, and nb where step-counter or quote strings changed.

Reviewed by Cursor Bugbot for commit a7bd3fa. Bugbot is set up for automated code reviews on this repo. Configure here.

@catalinradoiu catalinradoiu changed the title Feature/cradoiu/onboarding quick setup translation Add the translations for the texts used on the quick setup flow of the onboarding May 28, 2026
<string name="preOnboardingWelcomeDialogBody2">Изкуственият интелект винаги е по избор, а защитата на поверителността винаги е включена.</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d от %2$d</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">как се казва патица“ на английски</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">как се казва патица“ на английски</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unescaped ASCII quotes will be stripped by AAPT

Medium Severity

The onboardingSearchDaxDialogOption1Quoted Bulgarian string changed from proper Unicode typographic quotes („патица") to what appear to be unescaped ASCII double quotes ("патица"). AAPT treats paired unescaped ASCII " (U+0022) as string delimiters and strips them, so the quotation marks around "патица" will not appear in the UI. Every other locale uses either Unicode locale-specific quotes (Czech „kachna", Greek «πάπια») or escaped ASCII quotes (\"...\"), and the adjacent onboardingSearchDaxDialogOption1EnglishQuoted on line 1031 properly escapes with \"патица\".

Fix in Cursor Fix in Web

Triggered by learned rule: Do not flag string resource copy content (grammar, wording, phrasing)

Reviewed by Cursor Bugbot for commit e433ead. Configure here.

Translate strings to values-pt
<string name="preOnboardingWelcomeDialogBody1">Si pripravený/-á na rýchlejší prehliadač,\nktorý ti dáva kontrolu?</string>
<string name="preOnboardingWelcomeDialogBody2">Umelá inteligencia je vždy voliteľná\na ochrana súkromia je vždy zapnutá.</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d z %2$d</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d %2$d</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slovak step indicator lost "z" (of) preposition

Medium Severity

The Slovak onboardingStepIndicatorText changed from %1$d z %2$d to %1$d %2$d, accidentally dropping the preposition "z" (meaning "of"). This will display "1 3" instead of "1 z 3" (1 of 3) to Slovak users. Czech uses the same word (z) and other languages all have their equivalent preposition (Bulgarian "от", German "von", English "of").

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9c763a7. Configure here.

<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">hvordan si «and» på engelsk</string>
<string name="onboardingSearchDaxDialogOption1EnglishQuoted" instruction="translate &apos;duck&apos; too. Don&apos;t add question mark">hvordan si «and» på spansk</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">hvordan si «duck» på engelsk</string>
<string name="onboardingSearchDaxDialogOption1EnglishQuoted" instruction="translate &apos;duck&apos; too. Don&apos;t add question mark">hvordan si duck» på spansk</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing opening guillemet quote in Norwegian translation

Medium Severity

The onboardingSearchDaxDialogOption1EnglishQuoted string in the Norwegian translation is missing the opening « guillemet quote. The text reads hvordan si duck» på spansk but it needs to be hvordan si «duck» på spansk to match the quoting convention. The sibling string on the line above correctly uses «duck» with both quotes.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a323669. Configure here.

<string name="preOnboardingWelcomeDialogBody1">Chceš rychlejší prohlížeč, se kterým budeš mít vše pod kontrolou?</string>
<string name="preOnboardingWelcomeDialogBody2">Umělá inteligence je vždy volitelná a ochrana soukromí je vždy zapnutá.</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d z %2$d</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d %2$d</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Czech step indicator missing separator word "z"

High Severity

The Czech onboardingStepIndicatorText was changed from %1$d z %2$d to %1$d %2$d, dropping the word "z" (meaning "of"). This causes the step counter to display "1 3" instead of "1 z 3" (1 of 3). Every other locale has a separator word between the two placeholders (e.g., "of", "von", "от", "av", "de").


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b6cda70. Configure here.

<string name="preOnboardingWelcomeDialogBody2">La IA es siempre opcional y la protección de privacidad está siempre activada.</string>
<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d de %2$d</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">cómo se dice «pato» en inglés</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">cómo se dice «duck» en inglés</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish translation reverses "duck" to English breaking semantics

Low Severity

The onboardingSearchDaxDialogOption1Quoted string's instruction attribute explicitly says "translate 'duck' too," but the Spanish translation changed from «pato» (correct Spanish translation) to «duck» (English), making the demo query "how do you say 'duck' in English" — asking for the English translation of an already-English word. The same issue applies to Norwegian where «and» was changed to «duck».

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit edddd6f. Configure here.

<string name="onboardingStepIndicatorText" instruction="a counter above our instructions in onboarding that tells a user what step they are on">%1$d van %2$d</string>
<string name="onboardingSearchDaxDialogOption1Quoted" instruction="translate &apos;duck&apos; too.">hoe zeg je \'eend\' in het Engels?</string>
<string name="onboardingSearchDaxDialogOption1EnglishQuoted" instruction="translate &apos;duck&apos; too. Don&apos;t add question mark">hoe zeg je \'eend\' in het Spaans</string>
<string name="onboardingSearchDaxDialogOption1EnglishQuoted" instruction="translate &apos;duck&apos; too. Don&apos;t add question mark">hoe zeg je \'eend\' in het Nederlands</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dutch search suggestion asks self-referential circular query

Medium Severity

The onboardingSearchDaxDialogOption1EnglishQuoted target language was changed from in het Spaans (Spanish) to in het Nederlands (Dutch). Since the word being queried — 'eend' — is already Dutch, the search suggestion now reads "how do you say 'eend' in Dutch?" which is circular and nonsensical. Every other locale's EnglishQuoted variant asks about a foreign language (typically Spanish), matching the English default how to say "duck" in spanish.


Please tell me if this was useful or not with a 👍 or 👎.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6beb36b. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 7 total unresolved issues (including 6 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9bc66ef. Configure here.

<string name="quickSetupSearchOptionsTitle">Vil du have søgning og AI-chat i adresselinjen?</string>
<string name="quickSetupBottomSheetDone">Færdig</string>
<string name="quickSetupInputScreenSearchOnly">Kun søgning</string>
<string name="quickSetupInputScreenSearchAndDuckAi">Søgning og Duck.aie</string>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danish translation has typo "Duck.aie" instead of "Duck.ai"

Medium Severity

The Danish quickSetupInputScreenSearchAndDuckAi string reads Søgning og Duck.aie — the product name Duck.ai has a stray trailing "e". All other locales correctly use Duck.ai. This misspells the product name for Danish users.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9bc66ef. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant