Skip to content

Add 'View all Chats' in chat suggestions #8690

Merged
GerardPaligot merged 10 commits into
developfrom
feature/gerard/view-all-chats-shortcut
May 28, 2026
Merged

Add 'View all Chats' in chat suggestions #8690
GerardPaligot merged 10 commits into
developfrom
feature/gerard/view-all-chats-shortcut

Conversation

@GerardPaligot
Copy link
Copy Markdown
Contributor

@GerardPaligot GerardPaligot commented May 26, 2026 •
edited by malmstein
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214566301692454

Description

Adds a View all Chats shortcut at the bottom of the chat-suggestions list — both in the omnibar chat mode and in the unified input-screen Chat tab — so users with more than 8 stored chats can jump straight to the native chat-history screen without opening the browser menu. The row uses the same icon as the browser-menu Chats entry and inherits the same availability gate (historyScreen + native storage + Duck.ai enabled).

Steps to test this PR

Note

Prerequisites:

  • Install Internal Debug.
  • In Settings → Developer Settings → Feature Flags, confirm duckChat → historyScreen and duckChat → useNativeStorageChatData are ON, and Duck.ai itself is enabled.
  • Create at least 9 chats in Duck.ai so the > 8 threshold is exercised.

Happy path

  • Focus the omnibar and switch to chat mode → confirm the chat-suggestions list shows a divider + a View all Chats row directly under the chat list, using the same icon as the browser-menu Chats entry.
  • Tap View all Chats → confirm the native Chats screen opens.
  • Open the unified input screen → switch to the Chat tab → confirm the same shortcut appears in the same position with the same icon + copy.
  • Tap the shortcut from the input-screen Chat tab → confirm the Chats screen opens AND the input screen closes (back from the Chats screen returns to the previous browser tab, not to the input screen).

Guards

  • Delete chats one by one until 8 remain → confirm the View all Chats row disappears at exactly 8 (visible only when count > 8).
  • Re-add a chat to get back to 9 → confirm the shortcut returns on both surfaces.
  • Turn historyScreen OFF in Developer Settings → confirm the shortcut is hidden on both surfaces even with 9+ chats.

Edge cases

  • Start typing in the omnibar chat mode → confirm URL suggestions and "Search for [query]" appear below the View all Chats row (full order: chat history → View all Chats → URL suggestions → Search for).

UI changes

Before After
image image
image image

Note

Low Risk
UI-only navigation and analytics in Duck.ai suggestions, gated by existing chat-history feature flags with unit test coverage.

Overview
Adds a View all Chats row to Duck.ai chat suggestion lists on the omnibar native input and the unified input screen Chat tab, so users with a long chat list can open the native chat-history screen without the browser menu.

The row is wired through new onChatHistoryShortcutClicked callbacks (NativeInputManager, BrowserTabFragment, NativeInputModeWidget). It only shows when isChatHistoryAvailable() is true and there are more than 8 chat suggestions (ChatHistoryShortcutAdapter.VIEW_ALL_CHATS_THRESHOLD). In the concat list it sits after chat history and before URL / “Search for” rows. Taps fire DUCK_CHAT_SETTINGS_SIDEBAR_TAPPED and navigate via LaunchDuckChatHistory / openDuckChatHistory() to DuckChatHistoryNoParams (input screen also exits on launch).

Reviewed by Cursor Bugbot for commit 25ebfc3. Bugbot is set up for automated code reviews on this repo. Configure here.

@GerardPaligot Graphite App
Copy link
Copy Markdown
Contributor Author

GerardPaligot commented May 26, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GerardPaligot GerardPaligot force-pushed the feature/gerard/view-all-chats-shortcut branch from 391c1dc to 25ebfc3 Compare May 27, 2026 10:05
@GerardPaligot GerardPaligot marked this pull request as ready for review May 27, 2026 10:06
@malmstein malmstein self-assigned this May 27, 2026
malmstein
malmstein approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke-tested the APK and it works as expected — "View all Chats" appears once the threshold is reached and navigates to chat history cleanly. nice clean wiring through ChatHistoryShortcutAdapter + NativeInputChatSuggestionsBinder, and test coverage on the threshold + ConcatAdapter ordering is solid. main thing flagged below: the pixel name DUCK_CHAT_SETTINGS_SIDEBAR_TAPPED doesn't match the new surface and is going to conflate the settings sidebar tap with the suggestions shortcut tap in analytics — worth a fresh pixel. plus a couple of nits on a magic threshold and duplicated state across two VMs.

Comment thread app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Comment thread ...n/java/com/duckduckgo/duckchat/impl/inputscreen/ui/suggestions/ChatHistoryShortcutAdapter.kt
Comment thread .../src/main/java/com/duckduckgo/duckchat/impl/inputscreen/ui/viewmodel/InputScreenViewModel.kt
Comment thread ...uckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/NativeInputModeWidgetViewModel.kt
@GerardPaligot GerardPaligot mentioned this pull request May 28, 2026
Open
@malmstein
Copy link
Copy Markdown
Contributor

malmstein commented May 28, 2026

@GerardPaligot works as expected!

@GerardPaligot GerardPaligot merged commit e75c026 into develop May 28, 2026
38 checks passed
@GerardPaligot GerardPaligot deleted the feature/gerard/view-all-chats-shortcut branch May 28, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malmstein malmstein malmstein approved these changes

Assignees

@malmstein malmstein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GerardPaligot @malmstein