Added OAuth Authentication Method#72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds OAuth authentication support to the Descope PHP SDK and implements SDK identification headers for better analytics tracking.
Key Changes:
- Implements OAuth authentication flow with
start()andexchangeToken()methods - Adds SDK version tracking and custom headers (
x-descope-sdk-*) to API requests - Updates SSO token exchange to use consistent response handling
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SDK/Auth/OAuth.php | New OAuth authentication class with provider validation and token exchange |
| src/tests/Auth/OAuthTest.php | Comprehensive test coverage for OAuth functionality |
| src/SDK/DescopeSDK.php | Integration of OAuth component into main SDK class |
| src/SDK/EndpointsV1.php | Added SDK_VERSION constant for version tracking |
| src/SDK/Configuration/SDKConfig.php | Added SDK headers method and conditional debug logging |
| src/SDK/API.php | Integrated SDK identification headers into API requests |
| src/SDK/Auth/SSO.php | Updated SSO exchange token to match OAuth implementation pattern |
| .github/workflows/release.yml | Automated SDK version constant updates during release process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/12700
Fixes https://github.com/descope/etc/issues/12701
Related PRs
Description
Added OAuth authentication method and SDK API headers for better analytics.
Must