Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The round 3 Kyber reference implementation accepts unreduced coefficients for the public key, but hashes the unreduced coefficients into the shared secret, which binds them. ML-KEM instead checks whether the coefficients of a public key are reduced. Both approaches have up and downsides. Our Kyber implementation matches what the Kyber reference implementation did. This commit adds a comment noting that, so that GenAI doesn't warn about the mismatch with ML-KEM.
Contributor
|
Is there a reason to keep maintaining this version of kyber? |
lukevalenta
approved these changes
Jul 15, 2026
Member
Author
|
We should check how many users remain. It's a small diff on top of ML-KEM, so the bar is low. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The round 3 Kyber reference implementation accepts unreduced coefficients for the public key, but hashes the unreduced coefficients into the shared secret, which binds them.
ML-KEM instead checks whether the coefficients of a public key are reduced.
Both approaches have up and downsides. Our Kyber implementation matches what the Kyber reference implementation did.
This commit adds a comment noting that, so that GenAI doesn't warn about the mismatch with ML-KEM.