Pass Workflow retention through Agent.runWorkflow() so that tracking expiry matches instance state#1948
Draft
ericclemmons wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: c5acfeb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr – Pass Workflow instance retention through
Agent.runWorkflow()and apply the same terminal-outcome policy to local tracking expiry.Agent.runWorkflow()currently cannot configure the platform retention supported byWorkflow.create(), so callers must choose between automatic Agent tracking and custom Workflow retention.This adds the correctly typed
retentionoption, forwards it unchanged, stores normalized success and error retention for Agent SQLite tracking, and derivesexpires_atfrom the eventual outcome. Successful runs usesuccessRetention; errored and terminated runs useerrorRetention. Omitted values retain platform defaults while Agent tracking uses the bounded 30-day fallback from PR 1.References: PR 1, WorkflowInstanceCreateOptions