Report e2e-* checks on fork + Dependabot PRs#224
Open
lelia wants to merge 1 commit into
Open
Conversation
The e2e job is skipped on PRs that can't access repository secrets (forks and Dependabot). Because it's skipped via a job-level `if`, its matrix never expands, so the required e2e-* check contexts are never created and branch protection waits on them indefinitely, blocking merge. Add an e2e-bypass job whose `if` is the exact negation of the e2e job's run condition. It emits the same e2e-* check names with a passing status for fork/Dependabot PRs, satisfying branch protection without running the real tests. The two jobs are mutually exclusive and exhaustive: every PR runs exactly one. Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.4.0.dev5Docker image: |
e2e-* checks on fork + Dependabot PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
e2ejob is skipped on PRs that lack access to repository secrets - namely fork PRs and Dependabot PRs. Because the job is skipped via a job-levelif, its matrix never expands, so thee2e-*check contexts are never created. Branch protection is then stuck waiting on those required checks indefinitely (Expected — Waiting for status to be reported), permanently blocking PR merges.Fix
Add an
e2e-bypassjob whoseifis the exact negation of thee2ejob's run condition. It emits the samee2e-*check names (scan,sarif,reachability,gitlab,json,pypi) with a passing status for fork/Dependabot PRs, satisfying branch protection without running the real tests (which require secrets).The two jobs are mutually exclusive and exhaustive: every PR runs exactly one of them, never both, never neither. Push and
workflow_dispatchevents continue to run the real e2e suite.No branch-protection rule changes required.