Skip to content

Fix GRReSlimeTest on Pharo < 12 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbrichau merged 3 commits into from
Jul 8, 2026
Merged

Fix GRReSlimeTest on Pharo < 12 #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82fa30e
Fix GRReSlimeTest on Pharo < 12
marschall Jul 7, 2026
6580ee0
Fix GRPharoColorTest on Pharo 14
marschall Jul 7, 2026
717db82
Fix GRAnsiStringsRule on Pharo 14
marschall Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...se-Pharo110-Slime-Portability.package/GRAnsiStringsRule.class/instance/asSelectorNode..st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
private
asSelectorNode: aSymbol
^ (Smalltalk hasClassNamed: #OCSelectorNode)
ifTrue: [ (Smalltalk classNamed: #OCSelectorNode) value: aSymbol ]
ifFalse: [ aSymbol ]
2 changes: 1 addition & 1 deletion .../Grease-Pharo110-Slime-Portability.package/GRAnsiStringsRule.class/instance/initialize.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ initialize
argument value isCharacter
ifTrue: [ argument replaceWith: (RBLiteralNode value: (String with: argument value)) ] ].
newNode
selector: #subStrings:;
selector: (self asSelectorNode: #subStrings:);
yourself ]
7 changes: 6 additions & 1 deletion ...itory/Grease-Tests-Pharo-Core.package/GRPharoColorTest.class/instance/expectedFailures.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
testing
expectedFailures
^ #(testFromStringThreeDigit)
^ SystemVersion current major >= 14
ifTrue: [
"three digit color codes are fixed with Pharo 14"
#() ]
ifFalse: [
#(testFromStringThreeDigit) ]
1 change: 1 addition & 0 deletions ...ease-Tests-Pharo-Core.package/GRPharoColorTest.class/instance/testFromStringThreeDigit.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
testing
testFromStringThreeDigit
"These are all white on Pharo < 14"
self assert: (Color fromString: 'f00') = Color red.
self assert: (Color fromString: 'F00') = Color red.
self assert: (Color fromString: '#f00') = Color red.
Expand Down
4 changes: 3 additions & 1 deletion repository/Grease-Tests-Pharo-Slime.package/GRReSlimeTest.class/instance/setUp.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@ running
setUp

super setUp.
factory := ClassFactoryForTestCase environment: (ClassFactoryForTestCase environment).
factory := SystemVersion current major >= 12
ifTrue: [ ClassFactoryForTestCase environment: (ClassFactoryForTestCase environment) ]
ifFalse: [ ClassFactoryForTestCase new ].
environment := RBClassEnvironment new
Loading