Removing trailing space from protocol name as it can cause nasty issues#203
Merged
Conversation
For example, in GemStone you can have two protocols with the same name but one will not work properly. All because of the space in the protocol name
tukanos
force-pushed
the
protocolWithSpace
branch
from
April 27, 2026 13:57
6ff24f6 to
bd217d4
Compare
jbrichau
self-requested a review
July 7, 2026 08:11
jbrichau
approved these changes
Jul 7, 2026
jbrichau
left a comment
Member
There was a problem hiding this comment.
Looks good, though I don't know where they come from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, in GemStone you can have two protocols with the same name but one will not work properly. All because of the space in the protocol name