Add #greaseAsByteArray and implementation for Squeak#161
Merged
jbrichau merged 15 commits intoNov 4, 2023
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 84.57% 84.83% +0.25%
==========================================
Files 2017 2045 +28
Lines 13558 13790 +232
==========================================
+ Hits 11467 11699 +232
Misses 2091 2091
☔ View full report in Codecov by Sentry. |
Member
Author
|
@jbrichau I don't have GemStone. Could you add the necessary things for GemStone to this PR? |
Move extensions from LargeInteger to LargePositiveInteger
Move extensions from LargeInteger to LargePositiveInteger
…>>greaseByteCount on SmallInteger and LargeInteger
Member
|
It turns out GLASS does include @theseion I added the missing methods for GemStone. |
jbrichau
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
#asGreaseByteArrayas compatibility method forCollectionandInteger#asByteArraymethods.#asByteArraydoes not exist on integer classes in Squeak and GemStone.