Skip to content

Remove node24 installation. It's the default now#8014

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-node24-default
Jun 2, 2026
Merged

Remove node24 installation. It's the default now#8014
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-node24-default

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Jun 2, 2026 •
edited by coderabbitai Bot
Loading

Summary

Summary by CodeRabbit

  • Chores
    • Updated CI workflows: set CI=true and removed legacy Node.js pinning.
    • Simplified lint job setup by removing an explicit Node install step.
    • Added a workspace environment variable for the code-coverage job.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 5943cb42-e0f9-4c36-8424-78ffd9cd2fd3

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa4a8f and 0b9bc39.

📒 Files selected for processing (1)
  • .github/workflows/cron-ci.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/cron-ci.yaml
📝 Walkthrough

Walkthrough

Removes the temporary FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env from both workflows, adds CI: true to the main CI workflow, removes the manual Node.js 24 setup step from the lint job, and sets INSTA_WORKSPACE_ROOT in the cron-ci codecov job.

Changes

CI workflow environment cleanup

Layer / File(s) Summary
Workflow environment variable updates
.github/workflows/ci.yaml, .github/workflows/cron-ci.yaml		 Removes FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 from both workflows; adds CI: true to ci.yaml top-level env.
Remove manual Node.js setup from lint job
.github/workflows/ci.yaml		 Deletes the actions/setup-node step that pinned Node 24 in the lint job before Prek cache/installation steps.
Add codecov job env
.github/workflows/cron-ci.yaml		 Adds INSTA_WORKSPACE_ROOT: ${{ github.workspace }} to the codecov job's env block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • RustPython/RustPython#7685: Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 pinning to ci.yaml; touches the same env variable this PR removes.
  • RustPython/RustPython#7686: Adds FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 to cron-ci.yaml; touches the same env variable this PR removes.

Suggested reviewers

  • youknowone

Poem

🐰 I hopped through workflows late at night,
Removed a pin and set CI right,
Node's old shoe tucked away with care,
codecov finds workspace there—hooray! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: removing Node.js 24 installation because it's now the default, which aligns with the modifications to ci.yaml and cron-ci.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone merged commit 14cb5dd into RustPython:main Jun 2, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone