Skip to content

rename ssl-vendor to ssl-openssl-vendor#7989

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:ssl-openssl-vendor
May 28, 2026
Merged

rename ssl-vendor to ssl-openssl-vendor#7989
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:ssl-openssl-vendor

Conversation

@youknowone
Copy link
Copy Markdown
Member

@youknowone youknowone commented May 28, 2026 •
edited by coderabbitai Bot
Loading

see also #7985

Summary by CodeRabbit

  • Refactor

    • Renamed OpenSSL vendored build feature from ssl-vendor to ssl-openssl-vendor across all project configurations for consistency.

  • Documentation

    • Updated Windows SSL setup instructions to reflect the renamed build feature.

  • Tests

    • Updated CI test configurations to use the renamed OpenSSL build feature.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 0a81794c-6f6b-489e-ab6c-2d90c8dc2b7f

📥 Commits

Reviewing files that changed from the base of the PR and between 7d54ba5 and 8a15b09.

📒 Files selected for processing (4)
  • .github/workflows/ci.yaml
  • Cargo.toml
  • README.md
  • crates/stdlib/Cargo.toml
📝 Walkthrough

Walkthrough

The PR renames the Cargo feature ssl-vendor to ssl-openssl-vendor across the stdlib crate definition, root package wiring, CI test configuration, and user documentation for Windows OpenSSL setup.

Changes

Vendored OpenSSL feature rename

Layer / File(s) Summary
Stdlib crate feature definition
crates/stdlib/Cargo.toml		 ssl-openssl-vendor is introduced as the new feature name in the stdlib crate, replacing ssl-vendor while maintaining the same composition of ssl-openssl and openssl/vendored.
Root package feature wiring
Cargo.toml		 The root package adds ssl-openssl-vendor and removes ssl-vendor, wiring it to the corresponding renamed stdlib feature for downstream crate access.
CI test and documentation updates
.github/workflows/ci.yaml, README.md		 The CI test step for vendored OpenSSL build and Windows setup instructions in two README sections are updated to reference ssl-openssl-vendor instead of ssl-vendor.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • RustPython/RustPython#7985: Directly overlaps in CI SSL feature wiring and OpenSSL implementation changes for the same vendored OpenSSL feature.

Suggested reviewers

  • ShaharNaveh

Poem

🐰 A feature renamed with care and precision,
From ssl-vendor to ssl-openssl-vendor's vision,
Through stdlib, root, CI, and docs it flows,
Consistent and clear, wherever it goes!
🔐✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change across all modified files: renaming the ssl-vendor feature to ssl-openssl-vendor in Cargo.toml files, CI workflow, and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone requested a review from ShaharNaveh May 28, 2026 03:35
@youknowone youknowone marked this pull request as ready for review May 28, 2026 03:35
@youknowone youknowone enabled auto-merge (squash) May 28, 2026 03:35
ShaharNaveh
ShaharNaveh approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a better name for sure

@youknowone youknowone merged commit 1385c4e into RustPython:main May 28, 2026
26 checks passed
@youknowone youknowone deleted the ssl-openssl-vendor branch May 28, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowone @ShaharNaveh