Skip to content

Fix title() and capitalize() #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
May 9, 2026
Merged

Fix title() and capitalize() #7717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d8d34e
PyBytes.title should be ASCII-only.
joshuamegnauth54 Apr 26, 2026
edc87f2
Use icu_casemap over unicode-casing for titles
joshuamegnauth54 Apr 28, 2026
58d8b7c
Use icu_casemap for capitalize()
joshuamegnauth54 Apr 30, 2026
ce75f32
Match CPython's title() exactly
joshuamegnauth54 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 55 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,12 @@ termios = "0.3.3"
thiserror = "2.0"
timsort = "0.1.2"
tk-sys = { git = "https://github.com/arihant2math/tkinter.git", tag = "v0.2.0" }
icu_casemap = "2"
icu_locale = "2"
icu_properties = "2"
icu_normalizer = "2"
uuid = "1.23.1"
ucd = "0.1.1"
unicode-casing = "0.1.1"
unic-ucd-age = "0.9.0"
unicode_names2 = "2.0.0"
widestring = "1.2.0"
Expand All @@ -303,6 +304,7 @@ which = "8"
x509-cert = "0.2.5"
x509-parser = "0.18"
xml = "1.2"
writeable = "0.6"

# Lints

Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_str.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,6 @@ def test_upper(self):
self.assertEqual('\U0008fffe'.upper(), '\U0008fffe')
self.assertEqual('\u2177'.upper(), '\u2167')

@unittest.expectedFailure # TODO: RUSTPYTHON; ? ^
def test_capitalize(self):
string_tests.StringLikeTest.test_capitalize(self)
self.assertEqual('\U0001044F'.capitalize(), '\U00010427')
Expand All @@ -956,7 +955,6 @@ def test_capitalize(self):
self.assertEqual('finnish'.capitalize(), 'Finnish')
self.assertEqual('A\u0345\u03a3'.capitalize(), 'A\u0345\u03c2')

@unittest.expectedFailure # TODO: RUSTPYTHON; ? ^
def test_title(self):
super().test_title()
self.assertEqual('\U0001044F'.title(), '\U00010427')
Expand Down
6 changes: 3 additions & 3 deletions crates/vm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ result-like = { workspace = true }
timsort = { workspace = true }

## unicode stuff
# TODO: use unic for this; needed for title case:
# https://github.com/RustPython/RustPython/pull/832#discussion_r275428939
unicode-casing = { workspace = true }
icu_casemap = { workspace = true }
icu_locale = { workspace = true }
icu_properties = { workspace = true }
writeable = { workspace = true }

[target.'cfg(unix)'.dependencies]
rustix = { workspace = true }
Expand Down
Loading
Loading