Skip to content

Upgrade cspell to v10.0.0#7696

Merged
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:upgrade-cspell
Apr 27, 2026
Merged

Upgrade cspell to v10.0.0#7696
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:upgrade-cspell

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Apr 27, 2026 •
edited by coderabbitai Bot
Loading

Closes #7641

Summary by CodeRabbit

  • Chores
    • CI: normalized a workflow flag to a boolean and added a step to ensure Node 24 is available before linting.
  • Tooling
    • Pre-commit: upgraded the spell-check hook to v10.0.0 for improved checking and compatibility.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: b77a59a0-83b3-40dd-ae16-dceb3ec92161

📥 Commits

Reviewing files that changed from the base of the PR and between fb00aa6 and 64cc72d.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

Change CI workflow to use an unquoted YAML boolean for FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 and add an actions/setup-node step (Node 24) in the lint job; bump pre-commit streetsidesoftware/cspell-cli hook from v9.7.0 to v10.0.0.

Changes

Cohort / File(s) Summary
GitHub Actions CI Configuration
.github/workflows/ci.yaml		 Changed FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 from 'true' to true (YAML boolean) and added an actions/setup-node step to the lint job to install Node 24 with package-manager caching disabled.
Pre-commit Hook Dependencies
.pre-commit-config.yaml		 Bumped streetsidesoftware/cspell-cli pre-commit hook from v9.7.0 to v10.0.0 (upstream major release).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐇 I hopped through YAML, neat and bright,
I flipped a string to boolean light,
I tapped Node 24 in the linting trail,
and nudged cspell to a tenfold sail. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes changes to .github/workflows/ci.yaml (Node.js setup and environment variable adjustments) that are not mentioned in linked issue #7641, which only specifies updating cspell-cli. Review whether the CI workflow changes to FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 and Node.js setup are related to the cspell v10.0.0 upgrade requirements or if they should be submitted separately.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade cspell to v10.0.0' directly matches the main objective of the PR, which is updating the cspell-cli dependency from v9.7.0 to v10.0.0.
Linked Issues check ✅ Passed The PR successfully upgrades cspell-cli from v9.7.0 to v10.0.0 in .pre-commit-config.yaml, meeting the primary coding requirement from linked issue #7641.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 27, 2026
View reviewed changes
Comment thread .github/workflows/ci.yaml Fixed
@youknowone youknowone merged commit 1fa676f into RustPython:main Apr 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @github-advanced-security @youknowone