Add missing resource strings for Get-WinEvent#27397
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing GetEventResources entries referenced by Get-WinEvent parameter attributes so parameter-help lookup and tab completion can resolve those strings instead of hitting the missing-resource assertion described in issue #27393.
Changes:
- Added new resource strings for
Get-WinEventparameter help text inGetEventResources.resx. - Covered the missing help IDs for log, provider, path, max events, and computer name parameters.
- Centralized the fix in the diagnostics resource file used by the cmdlet metadata.
Comment on lines
+288
to
+289
| <data name="ListLogParamHelp" xml:space="preserve"> | ||
| <value>Specifies the event logs. Wildcards are permitted.</value> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
daxian-dbw
reviewed
May 5, 2026
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
@MartinGC94 Could you please fixes those 2 typos in the resource strings pointed out by Copilot? I will merge after that.
JustinGrote
pushed a commit
to JustinGrote/PowerShell
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The parameters for Get-WinEvent refer to help strings that don't actually exist.
This PR fixes that by adding the missing strings.
The text was copy+pasted from the existing help text (with some minor editing to cut out unnecessary details).
PR Context
Fixes: #27393
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header