Skip to content

fix: delegate should be set on nativeTextViewProtected #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanaelA merged 1 commit into from
Sep 23, 2020
Merged

fix: delegate should be set on nativeTextViewProtected #8881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/core/ui/text-view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class NoScrollAnimationUITextView extends UITextView {
@CSSType('TextView')
export class TextView extends TextViewBaseCommon {
nativeViewProtected: UITextView;
nativeTextViewProtected: UITextView;
Comment thread
NathanaelA marked this conversation as resolved.
private _delegate: UITextViewDelegateImpl;
_isShowingHint: boolean;
public _isEditing: boolean;
Expand Down Expand Up @@ -114,11 +115,11 @@ export class TextView extends TextViewBaseCommon {
@profile
public onLoaded() {
super.onLoaded();
this.ios.delegate = this._delegate;
this.nativeTextViewProtected.delegate = this._delegate;
Comment thread
NathanaelA marked this conversation as resolved.
}

public onUnloaded() {
this.ios.delegate = null;
this.nativeTextViewProtected.delegate = null;
super.onUnloaded();
}

Expand Down