Skip to content

fix(android/TextField): set focusable, clickable to false if not editable #8525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vtrifonov merged 2 commits into from
Apr 14, 2020
Merged

fix(android/TextField): set focusable, clickable to false if not editable #8525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5722e58
fix (android/TextField): set focusable, clickable to false when edita…
Rahul1d Apr 13, 2020
7a2a7aa
Merge branch 'master' into textField-issue-when-editable-is-false
vtrifonov Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nativescript-core/ui/editable-text-base/editable-text-base.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,13 @@ export abstract class EditableTextBase extends EditableTextBaseCommon {
this._keyListenerCache = listener;
}

// clear the listener if editable is false
// clear these fields instead of clearing listener.
// this allows input Type to be changed even after editable is false.
if (!this.editable) {
nativeView.setKeyListener(null);
nativeView.setFocusable(false);
nativeView.setFocusableInTouchMode(false);
nativeView.setLongClickable(false);
nativeView.setClickable(false);
}
}

Expand Down