fix-next: drawer plugin viewcontroller init#6379
Merged
Merged
Conversation
bec323a to
9eeb1c4
Compare
Contributor
Author
|
test pro_templates |
manoldonev
reviewed
Oct 10, 2018
manoldonev
reviewed
Oct 10, 2018
| return; | ||
| } | ||
|
|
||
| throw new Error("Root should be either UIViewController or UIView"); |
Contributor
There was a problem hiding this comment.
Looks like we have a scenario where viewController can be UIViewController but not UILayoutViewController -- previously we did not throw exception in this case but with the current flow I think we will.
634f8bd to
254c54f
Compare
manoldonev
approved these changes
Oct 11, 2018
Contributor
Author
|
test pro_templates |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the RadSideDrawer appearing black in
next. The problem was caused by #6102 . The issue was that we waited for the native views to be instantiated before we create the wrapper UILayoutViewController. RadSideDrawer checks its modes when its native view is created. It requires the view controller to be created before the native view.