Skip to content

fix(android): edge to edge default behaviour#11233

Merged
NathanWalker merged 1 commit into
mainfrom
fix/android-ete-default
May 31, 2026
Merged

fix(android): edge to edge default behaviour#11233
NathanWalker merged 1 commit into
mainfrom
fix/android-ete-default

Conversation

@triniwiz
Copy link
Copy Markdown
Member

@triniwiz triniwiz commented May 31, 2026 •
edited by NathanWalker
Loading

This pull request updates the handling of the androidOverflowEdge property in Android-specific UI components. The main change is to align the default behavior of overflow edge handling between the ContainerView and Page classes.

Android overflow edge handling:

  • Changed the default value of androidOverflowEdge in the ContainerView constructor from 'none' to 'ignore', which alters how overflow is managed for container views.
  • Added an explicit initialization of androidOverflowEdge to 'none' in the Page class constructor, ensuring consistent overflow edge behavior for pages.

@triniwiz
fix(android): edge to edge default behaviour
5faf740 
Pages consume the overflow by default, making it easier for containers to overflow once the page allows it .
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 31, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 5faf740

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 51s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-31 01:28:31 UTC

@NathanWalker
Copy link
Copy Markdown
Contributor

NathanWalker commented May 31, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3b4c39b4-ae4c-4f86-9b29-19f861f59243

📥 Commits

Reviewing files that changed from the base of the PR and between 41e7970 and 5faf740.

📒 Files selected for processing (2)
  • packages/core/ui/core/view/index.android.ts
  • packages/core/ui/page/index.android.ts
📝 Walkthrough

Walkthrough

This PR adjusts Android overflow edge behavior across the NativeScript view hierarchy. ContainerView changes its default from 'none' to 'ignore', while Page introduces an explicit constructor that sets its own default to 'none' before invoking parent initialization.

Changes

Android overflow edge defaults

Layer / File(s) Summary
Android overflow edge defaults
packages/core/ui/core/view/index.android.ts, packages/core/ui/page/index.android.ts		 ContainerView changes androidOverflowEdge default from 'none' to 'ignore' in its constructor. Page adds an explicit constructor to set androidOverflowEdge to 'none' and call super().

Suggested labels

♥ community PR

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Android edge-to-edge default behavior for overflow handling in UI components.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific modifications to androidOverflowEdge defaults in ContainerView and Page classes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/android-ete-default

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NathanWalker NathanWalker merged commit cbb348f into main May 31, 2026
8 checks passed
@NathanWalker NathanWalker deleted the fix/android-ete-default branch May 31, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees

No one assigned

Labels

♥ community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@triniwiz @NathanWalker