Add support for job token#876
Merged
Merged
Conversation
86295ca to
91fe5dc
Compare
max-wittig
reviewed
Sep 5, 2019
max-wittig
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR 👍
Could we just add some more tests and docs for this feature?
ef12fd4 to
a8439c1
Compare
Contributor
Author
|
@max-wittig All done. Please merge. |
max-wittig
requested changes
Sep 6, 2019
max-wittig
left a comment
Member
There was a problem hiding this comment.
Almost looks good! Just one small change
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://docs.gitlab.com/ee/api/jobs.html#get-job-artifacts for usage