Skip to content

[3.11] GH-109408: Move the C file whitespace check from patchcheck to pre-commit (GH-109890)#110640

Closed
AA-Turner wants to merge 3 commits into
python:3.11from
AA-Turner:backport-f5edb56-3.11
Closed

[3.11] GH-109408: Move the C file whitespace check from patchcheck to pre-commit (GH-109890)#110640
AA-Turner wants to merge 3 commits into
python:3.11from
AA-Turner:backport-f5edb56-3.11

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Oct 10, 2023 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit f5edb56)

@AA-Turner
[3.11] pythonGH-109408: Move the C file whitespace check from patchch…
fd8ddd4 
…eck to pre-commit (pythonGH-109890)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.
(cherry picked from commit f5edb56)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
Merged
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
Closed
@AA-Turner

AA-Turner commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

To be merged following #110641.

A

@AA-Turner

AA-Turner commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

Both this PR and #110641 are failing due to valid lint failures -- (in Tools/c-analyzer/cpython/_capi.py and Modules/_ctypes/darwin/dlfcn.h). We could add exclusions for these files, or perhaps just not backport? Unsure how best to proceed.

A

@AlexWaygood

AlexWaygood commented Oct 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Both this PR and #110641 are failing due to valid lint failures -- (in Tools/c-analyzer/cpython/_capi.py and Modules/_ctypes/darwin/dlfcn.h). We could add exclusions for these files, or perhaps just not backport? Unsure how best to proceed.

A

Adding excludes (or fixing the failures) seems like a good idea to me. It's useful to keep CI stuff in sync for all the maintenance branches.

Having said that, if there's loads of stuff that needs changing, I wouldn't bother -- it's not the end of the world if it's not backported!

@AlexWaygood

AlexWaygood commented Oct 11, 2023

Copy link
Copy Markdown
Member

Thanks! Closing for now, though, since the PR to main was reverted

@AA-Turner AA-Turner deleted the backport-f5edb56-3.11 branch January 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood will be requested when the pull request is marked ready for review AlexWaygood is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AA-Turner @AlexWaygood