Skip to content

Commit a349135

Browse files
Patrikmarschall
Patrik
authored and
marschall
committed
GRSlime rules inherit from the RB rules thus are incorrectly identified
Pharo uses unique identifier to identify rule class. Since GRSlime rules inherit from RB rules they inherit also their unique identifier. This patch creates unique identifier for the GRSlime classes. For more information see test ReSmallLintTest>>testUniqueIdentifierName in Pharo
1 parent 45ae270 commit a349135

12 files changed

Lines changed: 48 additions & 0 deletions

File tree

‎repository/Grease-Pharo110-Slime-Core.package/GRSlimeBlockLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeBlockLintRule'

‎repository/Grease-Pharo110-Slime-Core.package/GRSlimeParseTreeLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeParseTreeLintRule'

‎repository/Grease-Pharo110-Slime-Core.package/GRSlimeTransformationRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeTransformationRule'

‎repository/Grease-Pharo40-Slime.package/GRSlimeBlockLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeBlockLintRule'

‎repository/Grease-Pharo40-Slime.package/GRSlimeParseTreeLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeParseTreeLintRule'

‎repository/Grease-Pharo40-Slime.package/GRSlimeTransformationRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeTransformationRule'

‎repository/Grease-Pharo90-Slime.package/GRSlimeBlockLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeBlockLintRule'

‎repository/Grease-Pharo90-Slime.package/GRSlimeParseTreeLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeParseTreeLintRule'

‎repository/Grease-Pharo90-Slime.package/GRSlimeTransformationRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeTransformationRule'

‎repository/Grease-Slime.package/GRSlimeBlockLintRule.class/class/uniqueIdentifierName.st‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
accessing
2+
uniqueIdentifierName
3+
"This identifier should be unique. Should change only when the rule completely change semantics."
4+
^ 'SlimeBlockLintRule'

0 commit comments

Comments
 (0)