Skip to content

Modules, introduction#159

Merged
juuni26 merged 3 commits into
javascript-tutorial:masterfrom
tiana30:master
Nov 30, 2020
Merged

Modules, introduction#159
juuni26 merged 3 commits into
javascript-tutorial:masterfrom
tiana30:master

Conversation

@tiana30

@tiana30 tiana30 commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team October 24, 2020 03:29
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 24, 2020
Open
juuni26
juuni26 requested changes Nov 6, 2020
View reviewed changes

@juuni26 juuni26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tolong diperbaiki beberapa bahasanya gan. terima kasih telah membantu projek open source ini berkembang 👋

Comment thread 2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Outdated
Comment thread 2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md
Comment thread 2-ui/1-document/04-searching-elements-dom/1-find-elements/solution.md Outdated
Comment thread 2-ui/1-document/04-searching-elements-dom/1-find-elements/task.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Nov 6, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@tiana30

tiana30 commented Nov 13, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team November 13, 2020 12:51
juuni26
juuni26 approved these changes Nov 16, 2020
View reviewed changes

@juuni26 juuni26 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@juuni26 juuni26 merged commit 2b277d9 into javascript-tutorial:master Nov 30, 2020
@javascript-translate-bot

javascript-translate-bot commented Nov 30, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@tiana30

tiana30 commented Dec 15, 2020

Copy link
Copy Markdown
Contributor Author

halo saya mau ngasih tahu jadi file yang aku pull request disini kan ada dua yang satu modules: introduction dan yang satu Searching: getElement*, querySelector* jadi untuk file ini belum dicentang. apa harus di pull request lagi dengan judul file yang ini Searching: getElement*, querySelector*

@juuni26

juuni26 commented Dec 16, 2020

Copy link
Copy Markdown
Member

halo saya mau ngasih tahu jadi file yang aku pull request disini kan ada dua yang satu modules: introduction dan yang satu Searching: getElement*, querySelector* jadi untuk file ini belum dicentang. apa harus di pull request lagi dengan judul file yang ini Searching: getElement*, querySelector*

oke done ya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juuni26 juuni26 juuni26 approved these changes

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiana30 @javascript-translate-bot @juuni26