vared: avoid using local variables#8837
Merged
Merged
Conversation
krobelus
reviewed
Mar 27, 2022
| read -p 'set_color green; echo '$argv'; set_color normal; echo "> "' \ | ||
| (if not set -q $argv; echo -g; end) \ | ||
| -c "$$argv" \ | ||
| $argv |
Contributor
There was a problem hiding this comment.
LGTM. Any other complete solution would be more complicated.
The tmp and prompt variables collide with variables used as arguments. Just avoid them entirely, at the cost of making the internals of the functions somewhat more complicated. Closes fish-shell#8836.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tmp and prompt variables collide with variables used as arguments.
Just avoid them entirely, at the cost of making the internals of the
functions somewhat more complicated.
Fixes issue #8836.
TODOs: