Skip to content

Add gnome-extensions completion#8732

Merged
faho merged 1 commit into
fish-shell:masterfrom
szpak:gnomeExtensionsCompletion
Feb 17, 2022
Merged

Add gnome-extensions completion#8732
faho merged 1 commit into
fish-shell:masterfrom
szpak:gnomeExtensionsCompletion

Conversation

@szpak
Copy link
Copy Markdown
Contributor

@szpak szpak commented Feb 15, 2022

Description

This PR adds a completion for gnome-extensions, a CLI tool for managing GNOME shell extensions.

It's a man page for a reference:
https://manpages.ubuntu.com/manpages/focal/man1/gnome-extensions.1.html

I create it as a draft, as it is my first completion for Fish and I have a few questions about possible enhancements (see TODOs).

Possibly some things can be done easier, so please do not hesitate to make also other suggestions :).

TODOs:

  • User-visible changes noted in CHANGELOG.rst
  • 1. gnome-extensions list can only accept options/switches. Is it possible to show them if TAB is pressed? Now, one needs to write - to have the options shown.
  • 2. gnome-extensions create --uuid requires UUID value. Can do anything to suggest --uuid=? Or even block other -- completion until some UUID is passed?
  • 3. Similar situation with pack --out-dir where a directory should be passed.

Comment thread share/completions/gnome-extensions.fish Outdated
@szpak szpak force-pushed the gnomeExtensionsCompletion branch from 8eea5d7 to e5bc12b Compare February 16, 2022 17:02
@szpak szpak marked this pull request as ready for review February 16, 2022 17:05
@szpak szpak requested a review from faho February 17, 2022 19:34
@faho faho merged commit d485ed3 into fish-shell:master Feb 17, 2022
@faho
Copy link
Copy Markdown
Member

faho commented Feb 17, 2022

Merged, thanks!

@szpak szpak deleted the gnomeExtensionsCompletion branch February 17, 2022 19:55
@zanchey zanchey modified the milestones: fish-future, fish 3.4.0 Mar 10, 2022
@IlanCosman IlanCosman mentioned this pull request Mar 11, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants