This is an easy fix, just playing around with the codeql reports. Tracking issue for: - [x] https://github.com/fish-shell/fish-shell/security/code-scanning/95 (`column2_unit_len` should be of type 'int' but is of type 'unsigned long') - https://github.com/fish-shell/fish-shell/blob/1df7e9802f8e484f9328215ee5625bb2b8fa363d/src/timer.cpp#L190-L190 - [x] https://github.com/fish-shell/fish-shell/security/code-scanning/96 (`strlen(unit_short_name(fish_unit)) + 7` should be of type 'int' but is of type 'unsigned long') - https://github.com/fish-shell/fish-shell/blob/1df7e9802f8e484f9328215ee5625bb2b8fa363d/src/timer.cpp#L191-L191 - [x] https://github.com/fish-shell/fish-shell/security/code-scanning/97 (`column2_unit_len` should be of type 'int' but is of type 'unsigned long') - https://github.com/fish-shell/fish-shell/blob/1df7e9802f8e484f9328215ee5625bb2b8fa363d/src/timer.cpp#L192-L192 - [x] https://github.com/fish-shell/fish-shell/security/code-scanning/98 (`column2_unit_len` should be of type 'int' but is of type 'unsigned long') - https://github.com/fish-shell/fish-shell/blob/1df7e9802f8e484f9328215ee5625bb2b8fa363d/src/timer.cpp#L194-L194
This is an easy fix, just playing around with the codeql reports.
Tracking issue for:
column2_unit_lenshould be of type 'int' but is of type 'unsigned long')fish-shell/src/timer.cpp
Line 190 in 1df7e98
strlen(unit_short_name(fish_unit)) + 7should be of type 'int' but is of type 'unsigned long')fish-shell/src/timer.cpp
Line 191 in 1df7e98
column2_unit_lenshould be of type 'int' but is of type 'unsigned long')fish-shell/src/timer.cpp
Line 192 in 1df7e98
column2_unit_lenshould be of type 'int' but is of type 'unsigned long')fish-shell/src/timer.cpp
Line 194 in 1df7e98