Skip to content

Add completion for Starship#8520

Merged
faho merged 1 commit into
fish-shell:masterfrom
kidonng:patch-5
Dec 4, 2021
Merged

Add completion for Starship#8520
faho merged 1 commit into
fish-shell:masterfrom
kidonng:patch-5

Conversation

@kidonng
Copy link
Copy Markdown
Contributor

@kidonng kidonng commented Dec 2, 2021

Description

Starship is a popular prompt framework.

This PR adds a completion script that just calls Starship itself for the real stuff. Since Starship can be used as an single portable executable (in fact this is what its documentation promotes), this would eliminate the need to manually get the completions working.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added this to the fish 3.4.0 milestone Dec 4, 2021
@faho faho merged commit bacd47f into fish-shell:master Dec 4, 2021
@faho
Copy link
Copy Markdown
Member

faho commented Dec 4, 2021

Merged, thanks!

@kidonng kidonng deleted the patch-5 branch March 30, 2022 17:32
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants