Make fish_key_reader's output simpler#8467
Merged
Merged
Conversation
It now only prints the bind statement. Timing information and such is relegated to a separate "verbose" mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fish_key_readeris mostly used to tell people how to bind a certain key combination.However, by default it prints a lot of information that isn't useful for that and might be overwhelming:
Really, everything I need here is the first line to tell me what to do, and the last line to tell me the information I was looking for.
Everything in between is useful for debugging, but doesn't need to be the default.
So this relegates all the timing and per-character information to a "--verbose" mode, the default output is just the
bindcommand and instructions.The new output looks like:
TODOs: